Summary: | IDB: HTML5 Rocks Indexed Database demo fails | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||
Status: | ASSIGNED --- | ||||||||
Severity: | Normal | CC: | jonlee | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brady Eidson
2014-02-03 21:06:02 PST
Created attachment 223068 [details]
Patch v1
Of the large number of layout test failures, this fixes a handful! \o/ Comment on attachment 223068 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=223068&action=review > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:112 > + This is all fine except the statements are not in consistent order. Line 77-78 is open upper key, not closed upper key like in 85-86 and 92-93. > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:164 > + This looks good here. It might be slightly better to name the variables "hasLowerKey", "isLowerOpen", "hasUpperKey", "isUpperOpen", even though the current var names are more consistent with the IDB API. provisional r-! Created attachment 223071 [details]
Patch v2
Nice find, and good suggestion. New patch uploaded. Comment on attachment 223071 [details]
Patch v2
Provisional r=me!
Thanks for the eyes! http://trac.webkit.org/changeset/163364 and http://trac.webkit.org/changeset/163365 as a build fix followup Comment on attachment 223068 [details] Patch v1 Cleared Anders Carlsson's review+ from obsolete attachment 223068 [details] so that this bug does not appear in http://webkit.org/pending-commit. |