Bug 128126

Summary: Deconstructed parameters aren't being placed in the correct scope
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description Oliver Hunt 2014-02-03 14:25:40 PST
Deconstructed parameters aren't being placed in the correct scope
Comment 1 Oliver Hunt 2014-02-03 14:29:15 PST
Created attachment 223019 [details]
Patch
Comment 2 Antti Koivisto 2014-02-03 14:38:00 PST
Comment on attachment 223019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223019&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:67
> +    for (size_t i = 0; i < m_deconstructedParameters.size(); i++) {
> +        auto& entry = m_deconstructedParameters[i];

I would use range-for here and elsewhere.
Comment 3 Oliver Hunt 2014-02-03 14:39:32 PST
Committed r163328: <http://trac.webkit.org/changeset/163328>