Bug 128102

Summary: [Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, gyuyoung.kim, lucas.de.marchi, ossy, zalan, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Description Hunseop Jeong 2014-02-03 04:47:42 PST 
GraphicsContext::m_pixelSnappingFactor is uninitialized.
Comment 1 Hunseop Jeong 2014-02-03 05:08:13 PST 
Created attachment 222976 [details]
Patch
Comment 2 Ryuan Choi 2014-02-03 07:31:42 PST 
Comment on attachment 222976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222976&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL/Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized

It is introduced since r163265 but it looks ommitted GraphicsContextCairo.cpp

Nit, [Cairo] Looks enough because it is used by cairo based ports including GTK, EFL.
Comment 3 Zan Dobersek 2014-02-03 08:38:37 PST 
*** Bug 128105 has been marked as a duplicate of this bug. ***
Comment 4 zalan 2014-02-03 08:50:14 PST 
Looks correct to me. Sorry for the trouble, I didn't see cairo's extra ctor.
Comment 5 Csaba Osztrogonác 2014-02-03 08:52:42 PST 
Comment on attachment 222976 [details]
Patch

r=me with comment fix mentioned by Ryuan. Please fix it before landing.
Comment 6 Hunseop Jeong 2014-02-03 15:00:48 PST 
Created attachment 223026 [details]
Patch for landing
Comment 7 Jinwoo Song 2014-02-03 15:05:40 PST 
Comment on attachment 223026 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=223026&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::GraphicsContext::GraphicsContext): Initalized pixelSnappingFactor to 1 and 

Typo: s/Initalized/Initialized.
'Formatted to match the WebKit coding style' should be 'fixed the coding style violation'.
Comment 8 Hunseop Jeong 2014-02-03 15:23:37 PST 
Created attachment 223029 [details]
Patch
Comment 9 WebKit Commit Bot 2014-02-03 17:02:15 PST 
Comment on attachment 223029 [details]
Patch

Clearing flags on attachment: 223029

Committed r163348: <http://trac.webkit.org/changeset/163348>
Comment 10 WebKit Commit Bot 2014-02-03 17:02:22 PST 
All reviewed patches have been landed.  Closing bug.