| Summary: | IDB: Cannot open new databases with the default version | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alecflett, commit-queue, jsbell, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 124521 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brady Eidson
2014-02-02 21:51:05 PST
Created attachment 222959 [details]
Patch v1
Attachment 222959 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:475: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 222960 [details]
Patch v2 - Fix style by making code read the true intention
Comment on attachment 222959 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222959&action=review provisional r=me with the changes above. > Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:475 > + if (isNewDatabase && version == 0) { DefaultIntVersion? > Source/WebKit2/ChangeLog:10 > + have the magic âno version setâ version. Pretty quotes are not so pretty here. (In reply to comment #5) > (From update of attachment 222959 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222959&action=review > > provisional r=me with the changes above. > > > Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:475 > > + if (isNewDatabase && version == 0) { > > DefaultIntVersion? Yep, that's the intent. Fixed. > > > Source/WebKit2/ChangeLog:10 > > + have the magic âno version setâ version. > > Pretty quotes are not so pretty here. Fixed locally. Thanks! |