Bug 128096 - IDB: Cannot open new databases with the default version
Summary: IDB: Cannot open new databases with the default version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2014-02-02 21:51 PST by Brady Eidson
Modified: 2014-02-02 22:15 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (6.28 KB, patch)
2014-02-02 21:53 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 - Fix style by making code read the true intention (6.31 KB, patch)
2014-02-02 22:08 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-02 21:51:05 PST 
IDB: Cannot open new databases with the default version
Comment 1 Brady Eidson 2014-02-02 21:53:24 PST 
Created attachment 222959 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-02-02 21:54:37 PST 
Attachment 222959 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:475:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Radar WebKit Bug Importer 2014-02-02 22:07:22 PST 
<rdar://problem/15966919>
Comment 4 Brady Eidson 2014-02-02 22:08:01 PST 
Created attachment 222960 [details]
Patch v2 - Fix style by making code read the true intention
Comment 5 Jon Lee 2014-02-02 22:13:53 PST 
Comment on attachment 222959 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222959&action=review

provisional r=me with the changes above.

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:475
> +    if (isNewDatabase && version == 0) {

DefaultIntVersion?

> Source/WebKit2/ChangeLog:10
> +          have the magic âno version setâ version.

Pretty quotes are not so pretty here.
Comment 6 Brady Eidson 2014-02-02 22:15:22 PST 
(In reply to comment #5)
> (From update of attachment 222959 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222959&action=review
> 
> provisional r=me with the changes above.
> 
> > Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:475
> > +    if (isNewDatabase && version == 0) {
> 
> DefaultIntVersion?

Yep, that's the intent.  Fixed.

> 
> > Source/WebKit2/ChangeLog:10
> > +          have the magic âno version setâ version.
> 
> Pretty quotes are not so pretty here.

Fixed locally.  Thanks!
Comment 7 Brady Eidson 2014-02-02 22:15:52 PST 
http://trac.webkit.org/changeset/163287