Summary: | Stop using PLATFORM(MAC) in WTF except where it means “OS X but not iOS” | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, benjamin, cmarcelo, commit-queue, darin, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Attachment 222950 [details] did not pass style-queue:
ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
ERROR: Source/WTF/ChangeLog:7: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed <http://trac.webkit.org/r163288>. |
Created attachment 222950 [details] Replace PLATFORM(MAC) with equivalent alternatives appropriate for the context So that we can make PLATFORM(MAC) false when building for iOS, we need to replace all uses of it that don’t take iOS into account. Most such uses are about using Foundation, building for Cocoa, or targeting Darwin.