WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128089
Stop using PLATFORM(MAC) in WTF except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128089
Summary
Stop using PLATFORM(MAC) in WTF except where it means “OS X but not iOS”
mitz
Reported
2014-02-02 17:48:09 PST
Created
attachment 222950
[details]
Replace PLATFORM(MAC) with equivalent alternatives appropriate for the context So that we can make PLATFORM(MAC) false when building for iOS, we need to replace all uses of it that don’t take iOS into account. Most such uses are about using Foundation, building for Cocoa, or targeting Darwin.
Attachments
Replace PLATFORM(MAC) with equivalent alternatives appropriate for the context
(15.82 KB, patch)
2014-02-02 17:48 PST
,
mitz
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2014-02-02 17:50:02 PST
Attachment 222950
[details]
did not pass style-queue: ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WTF/ChangeLog:7: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 2
2014-02-02 23:27:09 PST
Committed <
http://trac.webkit.org/r163288
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug