Bug 128089 - Stop using PLATFORM(MAC) in WTF except where it means “OS X but not iOS”
Summary: Stop using PLATFORM(MAC) in WTF except where it means “OS X but not iOS”
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 17:48 PST by mitz
Modified: 2014-02-02 23:27 PST (History)
6 users (show)

See Also:

Attachments
Replace PLATFORM(MAC) with equivalent alternatives appropriate for the context (15.82 KB, patch)
2014-02-02 17:48 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-02-02 17:48:09 PST 
Created attachment 222950 [details]
Replace PLATFORM(MAC) with equivalent alternatives appropriate for the context

So that we can make PLATFORM(MAC) false when building for iOS, we need to replace all uses of it that don’t take iOS into account. Most such uses are about using Foundation, building for Cocoa, or targeting Darwin.
Comment 1 WebKit Commit Bot 2014-02-02 17:50:02 PST 
Attachment 222950 [details] did not pass style-queue:


ERROR: Source/WTF/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WTF/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 mitz 2014-02-02 23:27:09 PST 
Committed <http://trac.webkit.org/r163288>.