Bug 128070

Summary:

[GTK] Enabling web audio installs Composite.wav twice

Product:

WebKit

Reporter:

Maciej Piechotka <uzytkownik2>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

calvaris, commit-queue, pnormand, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Maciej Piechotka

Reported 2014-02-02 08:16:45 PST

Created attachment 222925 [details] Patch It looks like it's listed twice in install-data-am dependencies: install-data-am: install-audioDATA install-data-local \ install-dist_audioDATA install-dist_resourcesDATA \ This causes problems (at least on Gentoo) where install complains that file do already exists Changing it to: if ENABLE_WEB_AUDIO # Installing HRTF database wav files audiodir = ${datadir}/webkitgtk-@WEBKITGTK_API_VERSION@/resources/audio/ dist_audio_DATA = $(WebCore)/platform/audio/resources/Composite.wav endif # END ENABLE_WEB_AUDIO Should fix the problem.

Attachments
Patch (556 bytes, patch) 2014-02-02 08:16 PST, Maciej Piechotka	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

WebKit Commit Bot

Comment 1 2014-02-02 08:17:47 PST

Attachment 222925 [details] did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 2 2014-09-30 02:13:42 PDT

Sorry I missed this bug :/ We moved to CMake recently, is this issue still present with the new build system? Feel free to reopen this bug if needed.

Note You need to log in before you can comment on or make changes to this bug.