Bug 128070

Summary: [GTK] Enabling web audio installs Composite.wav twice
Product: WebKit Reporter: Maciej Piechotka <uzytkownik2>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: calvaris, commit-queue, pnormand, zan
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Maciej Piechotka 2014-02-02 08:16:45 PST
Created attachment 222925 [details]
Patch

It looks like it's listed twice in install-data-am dependencies:

install-data-am: install-audioDATA install-data-local \
        install-dist_audioDATA install-dist_resourcesDATA \

This causes problems (at least on Gentoo) where install complains that file do already exists

Changing it to:

if ENABLE_WEB_AUDIO
# Installing HRTF database wav files
audiodir = ${datadir}/webkitgtk-@WEBKITGTK_API_VERSION@/resources/audio/
dist_audio_DATA = $(WebCore)/platform/audio/resources/Composite.wav
endif  # END ENABLE_WEB_AUDIO

Should fix the problem.
Comment 1 WebKit Commit Bot 2014-02-02 08:17:47 PST
Attachment 222925 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Philippe Normand 2014-09-30 02:13:42 PDT
Sorry I missed this bug :/ We moved to CMake recently, is this issue still present with the new build system? Feel free to reopen this bug if needed.