Bug 128059

Summary: [EFL] REGRESSION(r163234) EFL debug build is broken
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, gyuyoung.kim, jsbell, lucas.de.marchi, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Hunseop Jeong 2014-02-01 19:53:56 PST 
EFL debug build is broken after r163234 on EFL.
Comment 1 Hunseop Jeong 2014-02-01 20:06:25 PST 
Created attachment 222902 [details]
Patch
Comment 2 Ryuan Choi 2014-02-01 20:39:08 PST 
Comment on attachment 222902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222902&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Because this is build fix, you can make the patch as "Unreviewed build fix"

> Source/WebCore/ChangeLog:11
> +        Fixed the broken build on EFL after r163234.
> +
> +        * Modules/indexeddb/IDBKeyData.cpp:
> +        (WebCore::IDBKeyData::loggingString): Added the default: case.

I am not sure whether it is EFL specific.

Maybe "Debug build is broken with INDEXED_DATABASE

> Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:279
>      }

Like other statements,

Can we add it out of switch() with "ASSERT_NOT_REACHED();"
Comment 3 Hunseop Jeong 2014-02-01 21:35:14 PST 
Created attachment 222906 [details]
Patch
Comment 4 Gyuyoung Kim 2014-02-01 21:48:55 PST 
Comment on attachment 222906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222906&action=review

You don't need to request review in unreviewed case.

> Source/WebCore/ChangeLog:3
> +        [EFL] REGRESSION(r163234) EFL debug build is broken

Remove [EFL] prefix.

> Source/WebCore/ChangeLog:6
> +        Unriewed. Debug build is broken with INDEXED_DATABASE.

Typo. Unreviewed.
Comment 5 Hunseop Jeong 2014-02-01 22:08:21 PST 
Created attachment 222909 [details]
Patch
Comment 6 WebKit Commit Bot 2014-02-01 23:57:43 PST 
Comment on attachment 222909 [details]
Patch

Clearing flags on attachment: 222909

Committed r163261: <http://trac.webkit.org/changeset/163261>
Comment 7 WebKit Commit Bot 2014-02-01 23:57:46 PST 
All reviewed patches have been landed.  Closing bug.