| Summary: | JSC profiler's stub info profiling support should work again | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 128039 | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2014-02-01 19:11:06 PST
Created attachment 222898 [details]
the patch
Attachment 222898 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:978: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp:52: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 222898 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:978: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] Fixed. > ERROR: Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp:52: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Lol, whoa - that's totally wrong. 4 spaces is clearly the only correct choice here. > Total errors found: 2 in 6 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 222898 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/163259 |