Summary: | IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 124521 | ||||||
Attachments: |
|
Description
Brady Eidson
2014-01-31 22:45:26 PST
Created attachment 222873 [details]
Patch v1
Comment on attachment 222873 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222873&action=review r=me with not even a nit, just a feckless comment: > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:213 > + bool isUnique = m_cursorDirection == IndexedDB::CursorDirection::NextNoDuplicate || m_cursorDirection == IndexedDB::CursorDirection::PrevNoDuplicate; This is slightly confusing, but I can't come up with a better solution here, so. |