Bug 128040

Summary: IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 jer.noble: review+

Brady Eidson
Reported 2014-01-31 22:45:26 PST
IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly
Attachments
Patch v1 (2.98 KB, patch)
2014-01-31 22:47 PST, Brady Eidson 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-01-31 22:47:31 PST
Created attachment 222873 [details] Patch v1
Jer Noble
Comment 2 2014-01-31 22:57:55 PST
Comment on attachment 222873 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222873&action=review r=me with not even a nit, just a feckless comment: > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:213 > + bool isUnique = m_cursorDirection == IndexedDB::CursorDirection::NextNoDuplicate || m_cursorDirection == IndexedDB::CursorDirection::PrevNoDuplicate; This is slightly confusing, but I can't come up with a better solution here, so.
Brady Eidson
Comment 3 2014-01-31 23:00:03 PST
http://trac.webkit.org/changeset/163237
Note You need to log in before you can comment on or make changes to this bug.