Bug 128029

Summary:

PlatformEvent::Type should be an enum class

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

andersca, bunhere, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
EWS round one fight	none
EWS round two fight	none
round 3	none

Blaze Burg

Reported 2014-01-31 16:55:50 PST

Also, with the enum class scoping it can be moved outside of the PlatformEvent class to keep the same level of qualification. I have a patch for this, which I'll rebase this weekend.

Attachments
EWS round one fight (84.10 KB, patch) 2014-02-03 01:24 PST, Blaze Burg	no flags	Details Formatted Diff Diff
EWS round two fight (85.41 KB, patch) 2014-02-03 10:10 PST, Blaze Burg	no flags	Details Formatted Diff Diff
round 3 (85.87 KB, patch) 2014-02-03 11:41 PST, Blaze Burg	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2014-02-03 01:24:41 PST

Created attachment 222971 [details] EWS round one fight

WebKit Commit Bot

Comment 2 2014-02-03 01:27:15 PST

Attachment 222971 [details] did not pass style-queue: ERROR: Source/WebCore/page/DragController.cpp:98: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1645: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:39: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 3 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.

Blaze Burg

Comment 3 2014-02-03 10:10:56 PST

Created attachment 222996 [details] EWS round two fight

WebKit Commit Bot

Comment 4 2014-02-03 10:14:02 PST

Attachment 222996 [details] did not pass style-queue: ERROR: Source/WebCore/page/DragController.cpp:98: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1645: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.

Blaze Burg

Comment 5 2014-02-03 11:41:36 PST

Created attachment 223003 [details] round 3

WebKit Commit Bot

Comment 6 2014-02-03 11:43:49 PST

Attachment 223003 [details] did not pass style-queue: ERROR: Source/WebCore/page/DragController.cpp:98: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1645: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 7 2014-02-06 13:02:10 PST

Patch looks OK, but I actually prefer PlatformEvent::Type::Foo.

Blaze Burg

Comment 8 2014-02-06 13:09:21 PST

(In reply to comment #7) > Patch looks OK, but I actually prefer PlatformEvent::Type::Foo. I can switch back if that's the preferred style here. I had originally moved it outside the class so it could be forward declared.

Note You need to log in before you can comment on or make changes to this bug.