Bug 127917

Summary: WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
Product: WebKit Reporter: David Farler <dfarler>
Component: Tools / TestsAssignee: chris fleizach <cfleizach>
Severity: Normal CC: cfleizach, commit-queue, dfarler
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Description Flags
patch none

Description David Farler 2014-01-30 10:00:18 PST
After 162986, https://bugs.webkit.org/show_bug.cgi?id=127688, an implementation for rowHeaders and columnHeaders was left out of AccessibilityUIElementIOS. We need stubs or reference a common Mac implementation of these methods.
Comment 1 chris fleizach 2014-01-30 10:01:35 PST
i'll take care of this now
Comment 2 David Farler 2014-01-30 10:04:58 PST
Thanks! I've added the Tools subdirectory to the CI builds.
Comment 3 chris fleizach 2014-01-30 10:06:13 PST
Created attachment 222681 [details]
Comment 4 David Farler 2014-01-30 10:42:31 PST
Sorry, one more thing - DumpRenderTree also needs implementations.
Comment 5 chris fleizach 2014-01-30 10:57:24 PST
(In reply to comment #4)
> Sorry, one more thing - DumpRenderTree also needs implementations.

Did DRT fail, because I saw this line was added

void AccessibilityUIElement::uiElementArrayAttributeValue(JSStringRef, Vector<AccessibilityUIElement>&) const { }
void AccessibilityUIElement::columnHeaders(Vector<AccessibilityUIElement>&) const { }
void AccessibilityUIElement::rowHeaders(Vector<AccessibilityUIElement>&) const { }
Comment 6 David Farler 2014-01-30 10:59:09 PST
It did but I must be behind that change, I don't have those lines in r163079. If those were added after that, then disregard and I'll update :)
Comment 7 chris fleizach 2014-01-30 14:20:11 PST
Comment on attachment 222681 [details]

Comment 8 WebKit Commit Bot 2014-01-30 14:48:08 PST
Comment on attachment 222681 [details]

Clearing flags on attachment: 222681

Committed r163117: <http://trac.webkit.org/changeset/163117>
Comment 9 WebKit Commit Bot 2014-01-30 14:48:10 PST
All reviewed patches have been landed.  Closing bug.