Bug 127908

Summary: [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mario: review-
patch none

Krzysztof Czech
Reported 2014-01-30 06:19:33 PST
Based on what w3c says, aria-controls could be exposed through ATK_RELATION_CONTROLLER_FOR.
Attachments
patch (20.93 KB, patch)
2014-01-30 06:46 PST, Krzysztof Czech 		mario: review-
DetailsFormatted DiffDiff
patch (22.98 KB, patch)
2014-01-31 02:20 PST, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-30 06:20:00 PST
<rdar://problem/15945816>
Krzysztof Czech
Comment 2 2014-01-30 06:46:02 PST
Created attachment 222666 [details] patch
Mario Sanchez Prada
Comment 3 2014-01-30 07:24:36 PST
Comment on attachment 222666 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=222666&action=review The patch looks good to me, but you need to add empty stubs for Mac and iOS too. More specifically, the missing stubs would go to: Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1027 > + Extra line
Krzysztof Czech
Comment 4 2014-01-30 07:31:14 PST
> The patch looks good to me, but you need to add empty stubs for Mac and iOS too. More specifically, the missing stubs would go to: > > Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm > Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm > Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1027 > > + > > Extra line Ops, right I forgot, thanks.
Krzysztof Czech
Comment 5 2014-01-31 02:20:13 PST
Created attachment 222806 [details] patch
WebKit Commit Bot
Comment 6 2014-02-03 01:12:07 PST
Comment on attachment 222806 [details] patch Clearing flags on attachment: 222806 Committed r163296: <http://trac.webkit.org/changeset/163296>
WebKit Commit Bot
Comment 7 2014-02-03 01:12:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.