Bug 127885

Summary:

Web Inspector: Play Breakpoint Sound in Frontend

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+

Description Joseph Pecoraro 2014-01-29 19:48:12 PST

This was refactored as part of the move of ScriptDebugServer/InspectorDebuggerAgent into JavaScriptCore. Make it work again!

Comment 1 Radar WebKit Bug Importer 2014-01-29 19:48:26 PST

<rdar://problem/15943579>

Comment 2 Joseph Pecoraro 2014-01-29 20:02:05 PST

Created attachment 222622 [details]
[PATCH] Proposed Fix

Please suggest a better name than "breakpointSound". I don't like it =(.

Comment 3 Timothy Hatcher 2014-01-29 20:26:05 PST

Comment on attachment 222622 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222622&action=review

> Source/JavaScriptCore/inspector/ScriptDebugListener.h:76
> +    virtual void breakpointActionSound(int breakpointActionIdentifier) = 0;

Can we use unsigned? I hate int for things that don't need to be negative. Positive positive positive!

> Source/JavaScriptCore/inspector/protocol/Debugger.json:304
> +            "name": "breakpointSound",

playBreakpointSound? Any verb would help here.

Comment 4 Timothy Hatcher 2014-01-29 20:51:25 PST

playBreakpointActionSound even.

Comment 5 Joseph Pecoraro 2014-01-30 10:29:04 PST

Landed <http://trac.webkit.org/changeset/163071>.

Comment 6 Timothy Hatcher 2014-02-27 08:47:41 PST

*** Bug 126906 has been marked as a duplicate of this bug. ***