| Summary: | [CSS Shapes] Rounded Insets Let Content Overlap Shape | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bear Travis <betravis> | ||||||||||
| Component: | CSS | Assignee: | Zoltan Horvath <zoltan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bjonesbe, commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, webkit-bug-importer, zoltan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 124173 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 223352 [details]
Patch
Created attachment 223354 [details]
Patch
Comment on attachment 223354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223354&action=review > Source/WebCore/css/LengthFunctions.h:41 > +FloatSize floatSizeForLengthSize(const LengthSize&, float maxWidth, float maxHeight); I think it's ok as is, but I could see an argument for using a const FloatSize& instead of two floats. I'll leave that call up to you, since I'm not sure if it's better or not. Created attachment 223405 [details]
Patch for landing
I'm landing it with LayoutSize.
I meant FloatSize. Comment on attachment 223405 [details] Patch for landing Clearing flags on attachment: 223405 Committed r163585: <http://trac.webkit.org/changeset/163585> All reviewed patches have been landed. Closing bug. |
Created attachment 222591 [details] Test case In some cases, inline content overlaps with insets with a round applied. Appears to depend on the size of the float shape.