|Product:||WebKit||Reporter:||Csaba Osztrogonác <ossy>|
|Component:||New Bugs||Assignee:||Csaba Osztrogonác <ossy>|
|Severity:||Normal||CC:||benjamin, bunhere, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, graouts, gyuyoung.kim, japhet, joepeck, kondapallykalyan, mark.lam, mkwst, oliver, ossy, rakuco, timothy|
|Version:||528+ (Nightly build)|
Description Csaba Osztrogonác 2014-01-29 09:27:52 PST
Comment 2 Mark Lam 2014-01-29 09:43:07 PST
Comment on attachment 222576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222576&action=review r=me with the one issue addressed. > Source/WebCore/inspector/InspectorInstrumentation.cpp:-1132 > - Please revert the removal of this empty line.
Comment 3 Csaba Osztrogonác 2014-01-29 10:27:58 PST
Committed r163024: <http://trac.webkit.org/changeset/163024>
Comment 4 Csaba Osztrogonác 2014-01-29 10:30:47 PST
(In reply to comment #2) > Please revert the removal of this empty line. Thanks for noticing this typo, I removed it before landing.
Comment 5 Joseph Pecoraro 2014-01-29 10:35:23 PST
Hehe, I just wrote up a patch that did this yesterday and was going to send it out today. Thanks for taking care of this!
Comment 6 Joseph Pecoraro 2014-01-29 10:39:04 PST
Comment 7 Csaba Osztrogonác 2014-01-29 10:44:12 PST
Comment 8 Joseph Pecoraro 2014-01-29 10:46:08 PST
(In reply to comment #7) > (In reply to comment #5) > > Hehe, I just wrote up a patch that did this yesterday and was going to send it out today. Thanks for taking care of this! > > I checked the bugzilla and haven't found bug report about it. I didn't create a bug for it. I just posted that comment saying we should remove it, and started on a patch locally. Triggered a build and had to leave early. =) Not a problem, it puts me in a good place to review this patch.