Bug 127833

Summary: Remove the ACCELERATED_COMPOSITING flag
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebKit Misc.Assignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, allan.jensen, andersca, benjamin, bunhere, cdumez, cgarcia, cmarcelo, commit-queue, dino, d-r, dstockwell, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, jamesr, japhet, jer.noble, kangil.han, kondapallykalyan, luiz, macpherson, menard, mrobinson, noam, philipj, pnormand, roger_fong, sergio, simon.fraser, tonikitoo, WebkitBugTracker, zeno
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing with Cairo fix none

Andrei Bucur
Reported 2014-01-29 00:27:14 PST
Accelerated compositing is enabled by default on the main platforms. Also, other major WebKit ports plan to enable it sometimes in the near future. Given this information, remove the flag and make AC mandatory.
Attachments
Patch (434.85 KB, patch)
2014-01-29 06:26 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch for landing (434.65 KB, patch)
2014-01-30 01:12 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch for landing with Cairo fix (434.83 KB, patch)
2014-01-30 01:39 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2014-01-29 06:26:32 PST
Created attachment 222569 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-29 06:28:46 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Andrei Bucur
Comment 3 2014-01-29 06:35:24 PST
I'll need some help from the port maintainers to take a look over it (and make sure this is safe to land). The patch doesn't change any build system configurations or scripts. Basically, if the flag is set, it's never used by the code. This gives freedom to the port maintainers to adjust their infrastructure as they see fit.
Alex Christensen
Comment 4 2014-01-29 10:59:13 PST
I'd like https://bugs.webkit.org/show_bug.cgi?id=127843 landed before this patch. https://bugs.webkit.org/show_bug.cgi?id=127844 won't be necessary any more after this patch, though. I'm in favor of this change, and I don't want WinCairo to break or hold back this development.
Andrei Bucur
Comment 5 2014-01-30 01:12:23 PST
Created attachment 222643 [details] Patch for landing
Andrei Bucur
Comment 6 2014-01-30 01:39:33 PST
Created attachment 222644 [details] Patch for landing with Cairo fix
WebKit Commit Bot
Comment 7 2014-01-30 02:18:00 PST
Comment on attachment 222644 [details] Patch for landing with Cairo fix Clearing flags on attachment: 222644 Committed r163079: <http://trac.webkit.org/changeset/163079>
WebKit Commit Bot
Comment 8 2014-01-30 02:18:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.