Bug 127824

Summary: WKRemoteObjectCoder should support more argument types
Product: WebKit Reporter: Ian Henderson <ian>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
andersca: review+, ian: commit-queue-
revised patch none

Ian Henderson
Reported 2014-01-28 20:07:29 PST
BOOL becomes char on some platforms, so we need to support at least 'c'.
Attachments
proposed patch (1.27 KB, patch)
2014-01-28 20:09 PST, Ian Henderson 		andersca: review+
ian: commit-queue-
DetailsFormatted DiffDiff
revised patch (1.86 KB, patch)
2014-01-28 20:31 PST, Ian Henderson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ian Henderson
Comment 1 2014-01-28 20:09:32 PST
Created attachment 222548 [details] proposed patch
Anders Carlsson
Comment 2 2014-01-28 20:24:54 PST
Comment on attachment 222548 [details] proposed patch What about decoding?
Ian Henderson
Comment 3 2014-01-28 20:31:33 PST
Created attachment 222551 [details] revised patch
Ian Henderson
Comment 4 2014-01-28 20:32:55 PST
It's strange that things seemed to work without throwing exceptions. I updated the decoding method too.
WebKit Commit Bot
Comment 5 2014-01-28 21:09:33 PST
Comment on attachment 222551 [details] revised patch Clearing flags on attachment: 222551 Committed r163000: <http://trac.webkit.org/changeset/163000>
WebKit Commit Bot
Comment 6 2014-01-28 21:09:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.