Bug 127809

Summary: REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, koivisto, kondapallykalyan
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
another andersca: review+

Alexey Proskuryakov
Reported 2014-01-28 15:37:41 PST
css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html fail with a timeout on debug bots every time after <http://trac.webkit.org/r162947>. This is also reproducible locally.
Attachments
patch (6.01 KB, patch)
2014-01-29 07:40 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (3.92 KB, patch)
2014-01-29 07:43 PST, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-01-28 15:44:45 PST
Skipped in <http://trac.webkit.org/r162974>. Antti is going to investigate tomorrow.
Antti Koivisto
Comment 2 2014-01-29 07:40:41 PST
Created attachment 222571 [details] patch
Antti Koivisto
Comment 3 2014-01-29 07:43:04 PST
Created attachment 222572 [details] another
Anders Carlsson
Comment 4 2014-01-29 07:55:41 PST
Comment on attachment 222572 [details] another View in context: https://bugs.webkit.org/attachment.cgi?id=222572&action=review I don't like the "gridSize()" concept, but I can't really think of something better... > Source/WebCore/rendering/RenderView.cpp:640 > + static const unsigned maximumRepaintRegionGridSize = 16 * 16; > + if (m_accumulatedRepaintRegion->gridSize() > maximumRepaintRegionGridSize) > + m_accumulatedRepaintRegion = std::make_unique<Region>(m_accumulatedRepaintRegion->bounds()); I think this could use a comment.
Antti Koivisto
Comment 5 2014-01-29 08:07:36 PST
https://trac.webkit.org/r163019
Note You need to log in before you can comment on or make changes to this bug.