Bug 127807

Summary: Heap::writeBarrier shouldn't be static
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 128324    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Mark Hahnenberg 2014-01-28 15:19:14 PST 
Currently it looks up the Heap in which to fire the write barrier by using the cell passed to it. Pretty much every call site already has a reference to the VM or the Heap itself. It seems wasteful to look it up all over again.
Comment 1 Mark Hahnenberg 2014-01-28 15:25:46 PST 
Created attachment 222507 [details]
Patch
Comment 2 Mark Hahnenberg 2014-01-28 15:27:31 PST 
Created attachment 222508 [details]
Patch
Comment 3 Geoffrey Garen 2014-01-28 22:03:39 PST 
Comment on attachment 222508 [details]
Patch

r=me if you fix the build
Comment 4 Mark Hahnenberg 2014-02-05 21:06:04 PST 
Created attachment 223302 [details]
Patch
Comment 5 Mark Hahnenberg 2014-02-05 21:06:18 PST 
(In reply to comment #4)
> Created an attachment (id=223302) [details]
> Patch

EWS fodder.
Comment 6 Mark Hahnenberg 2014-02-05 21:56:10 PST 
Created attachment 223306 [details]
Patch
Comment 7 Mark Hahnenberg 2014-02-06 09:54:31 PST 
Committed r163542: <http://trac.webkit.org/changeset/163542>
Comment 8 WebKit Commit Bot 2014-02-06 12:15:42 PST 
Re-opened since this is blocked by bug 128324
Comment 9 Mark Hahnenberg 2014-02-06 15:15:00 PST 
Created attachment 223388 [details]
Patch
Comment 10 Mark Hahnenberg 2014-02-06 15:16:15 PST 
Created attachment 223390 [details]
Patch
Comment 11 Geoffrey Garen 2014-02-06 15:24:58 PST 
Comment on attachment 223390 [details]
Patch

r=me
Comment 12 WebKit Commit Bot 2014-02-06 16:37:31 PST 
Comment on attachment 223390 [details]
Patch

Clearing flags on attachment: 223390

Committed r163576: <http://trac.webkit.org/changeset/163576>
Comment 13 WebKit Commit Bot 2014-02-06 16:37:34 PST 
All reviewed patches have been landed.  Closing bug.