Bug 127807

Summary:

Heap::writeBarrier shouldn't be static

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

128324

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Mark Hahnenberg

Reported 2014-01-28 15:19:14 PST

Currently it looks up the Heap in which to fire the write barrier by using the cell passed to it. Pretty much every call site already has a reference to the VM or the Heap itself. It seems wasteful to look it up all over again.

Attachments
Patch (21.02 KB, patch) 2014-01-28 15:25 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (20.63 KB, patch) 2014-01-28 15:27 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (18.92 KB, patch) 2014-02-05 21:06 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (21.68 KB, patch) 2014-02-05 21:56 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (19.04 KB, patch) 2014-02-06 15:15 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (21.75 KB, patch) 2014-02-06 15:16 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.