Bug 127805

Summary: Remove some unneeded debugger code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, joepeck, mhahnenberg, msaboff, oliver, ossy, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. oliver: review+

Mark Lam
Reported 2014-01-28 15:04:54 PST
JSC will now always support the debugger. Hence, the #if ENABLE(JAVASCRIPT_DEBUGGER) checks can be removed. DebuggerCallFrame::callFrame() is also unused and will be removed.
Attachments
the patch. (18.36 KB, patch)
2014-01-28 15:06 PST, Mark Lam 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-01-28 15:06:58 PST
Created attachment 222502 [details] the patch.
Mark Lam
Comment 2 2014-01-28 15:26:47 PST
Thanks. Landed in r162970: <http://trac.webkit.org/r162970>.
Joseph Pecoraro
Comment 3 2014-01-28 15:33:26 PST
Comment on attachment 222502 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=222502&action=review > Source/JavaScriptCore/ChangeLog:9 > + JSC will now always support the debugger. Hence, the #if ENABLE(JAVASCRIPT_DEBUGGER) > + checks can be removed. Lets just remove the ENABLE flag everywhere.
Csaba Osztrogonác
Comment 4 2014-01-29 09:28:08 PST
(In reply to comment #3) > (From update of attachment 222502 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222502&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + JSC will now always support the debugger. Hence, the #if ENABLE(JAVASCRIPT_DEBUGGER) > > + checks can be removed. > > Lets just remove the ENABLE flag everywhere. Let's do it in https://bugs.webkit.org/show_bug.cgi?id=127840
Note You need to log in before you can comment on or make changes to this bug.