| Summary: | EFL port should stop using COMPILE_ASSERT_MATCHING_ENUM macros | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 222561 [details]
Patch
Comment on attachment 222561 [details]
Patch
Thanks a lot for doing this!
Comment on attachment 222561 [details] Patch Clearing flags on attachment: 222561 Committed r163033: <http://trac.webkit.org/changeset/163033> All reviewed patches have been landed. Closing bug. (In reply to comment #1) > Created an attachment (id=222561) [details] > Patch Thanks Ryuan :) |
Instead of having COMPILE_ASSERT_MATCHING_ENUM macros, WebKit EFL should have functions that can map between different types. For example: inline WKSameDocumentNavigationType toAPI(SameDocumentNavigationType type) { WKFrameNavigationType wkType = kWKSameDocumentNavigationAnchorNavigation; switch (type) { case SameDocumentNavigationAnchorNavigation: wkType = kWKSameDocumentNavigationAnchorNavigation; break; case SameDocumentNavigationSessionStatePush: wkType = kWKSameDocumentNavigationSessionStatePush; break; case SameDocumentNavigationSessionStateReplace: wkType = kWKSameDocumentNavigationSessionStateReplace; break; case SameDocumentNavigationSessionStatePop: wkType = kWKSameDocumentNavigationSessionStatePop; break; } return wkType; } This allows us to change the enum values in WebCore without breaking the builds.