Bug 127788

Summary: WebKit2 View Gestures (Swipe): Encode snapshots as JPEG on some platforms
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
fix the iOS build andersca: review+

Description Tim Horton 2014-01-28 12:46:43 PST 
See http://trac.webkit.org/changeset/162950
Comment 1 Radar WebKit Bug Importer 2014-01-28 12:47:20 PST 
<rdar://problem/15928241>
Comment 2 Tim Horton 2014-05-12 16:48:53 PDT 
*** Bug 132844 has been marked as a duplicate of this bug. ***
Comment 3 Tim Horton 2014-05-12 18:10:38 PDT 
Created attachment 231351 [details]
patch
Comment 4 WebKit Commit Bot 2014-05-12 18:12:32 PDT 
Attachment 231351 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2014-05-12 22:12:29 PDT 
Created attachment 231361 [details]
fix the iOS build
Comment 6 WebKit Commit Bot 2014-05-12 22:13:35 PDT 
Attachment 231361 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2014-05-13 11:03:18 PDT 
Comment on attachment 231361 [details]
fix the iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=231361&action=review

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:247
> +void ViewSnapshotStore::reduceSnapshotMemoryCost(String uuid)

const String& uuid.

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:271
> +void ViewSnapshotStore::didCompressSnapshot(String uuid, RetainPtr<CGImageRef> newImage, size_t newImageSize)

const String& uuid.
Comment 8 Tim Horton 2014-05-13 11:15:46 PDT 
http://trac.webkit.org/changeset/168689
Comment 9 Tim Horton 2014-05-13 14:28:16 PDT 
Build fix in http://trac.webkit.org/changeset/168739
Comment 10 Tim Horton 2014-05-13 14:36:28 PDT 
And http://trac.webkit.org/changeset/168740 for the sim.