Summary: | Subpixel rendering: Make RoundedRect layout unit aware. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, d-r, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 127524 | ||||||||||||||
Attachments: |
|
Description
zalan
2014-01-28 08:17:14 PST
Created attachment 222445 [details]
Patch
Alternatively, we could use FloatRoundedRect instead of LayouUnit based RoundedRect. Attachment 222445 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Pls fix the red. Created attachment 222472 [details]
Patch
Attachment 222472 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #7) > Attachment 222472 [details] did not pass style-queue: > > > ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > Total errors found: 2 in 11 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. The style checker gets confused and reports whitespace/indent issue on this, while it actually fails on the following line: (will file a bug against webkit-check-style) RenderBoxModelObject::clipBorderSidePolygon() -> secondQuad[1] = side == BSTop || side == BSBottom ? FloatPoint(quad[0].x(), quad[1].y()) : FloatPoint(quad[1].x(), quad[0].y()); Created attachment 222482 [details]
Patch
Comment on attachment 222482 [details]
Patch
ews first.
Created attachment 222546 [details]
Patch
Comment on attachment 222546 [details]
Patch
EWS (failed mac-wk2 before)
Created attachment 222786 [details]
Patch
Comment on attachment 222786 [details]
Patch
EWS testing the other platform bots.
Comment on attachment 222786 [details] Patch Clearing flags on attachment: 222786 Committed r163156: <http://trac.webkit.org/changeset/163156> All reviewed patches have been landed. Closing bug. |