Bug 127770

Summary: Refactoring design-mode-spellcheck-off.html to use asynchronous spellchecking
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125689    
Attachments:
Description Flags
Patch rniwa: review+

Description Grzegorz Czajkowski 2014-01-28 02:46:49 PST 
Enable asynchronous spellchecking in design-mode-spellcheck-off.html.
Comment 1 Grzegorz Czajkowski 2014-01-28 02:49:20 PST 
Created attachment 222426 [details]
Patch
Comment 2 Grzegorz Czajkowski 2014-02-10 00:08:31 PST 
Comment on attachment 222426 [details]
Patch

Hi Ryosuke, I am looking forward to seeing your comments.
Comment 3 Ryosuke Niwa 2014-02-13 23:42:22 PST 
Comment on attachment 222426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222426&action=review

> LayoutTests/editing/spelling/design-mode-spellcheck-off.html:4
> +<script src="../editing.js"></script>

Looks like we can just include this inside body like the other script element.

> LayoutTests/editing/spelling/design-mode-spellcheck-off.html:27
> +    if (!window.internals)
> +        return;
>  

It would be better if we had this check before shouldBecomeDifferent
so that we can test it in the browser as well as DRT/WTR.
Comment 4 Grzegorz Czajkowski 2014-02-14 05:54:05 PST 
Committed r164101: <http://trac.webkit.org/changeset/164101>