Bug 127770

Summary: Refactoring design-mode-spellcheck-off.html to use asynchronous spellchecking
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125689    
Attachments:
Description Flags
Patch rniwa: review+

Grzegorz Czajkowski
Reported 2014-01-28 02:46:49 PST
Enable asynchronous spellchecking in design-mode-spellcheck-off.html.
Attachments
Patch (5.75 KB, patch)
2014-01-28 02:49 PST, Grzegorz Czajkowski 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2014-01-28 02:49:20 PST
Created attachment 222426 [details] Patch
Grzegorz Czajkowski
Comment 2 2014-02-10 00:08:31 PST
Comment on attachment 222426 [details] Patch Hi Ryosuke, I am looking forward to seeing your comments.
Ryosuke Niwa
Comment 3 2014-02-13 23:42:22 PST
Comment on attachment 222426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222426&action=review > LayoutTests/editing/spelling/design-mode-spellcheck-off.html:4 > +<script src="../editing.js"></script> Looks like we can just include this inside body like the other script element. > LayoutTests/editing/spelling/design-mode-spellcheck-off.html:27 > + if (!window.internals) > + return; > It would be better if we had this check before shouldBecomeDifferent so that we can test it in the browser as well as DRT/WTR.
Grzegorz Czajkowski
Comment 4 2014-02-14 05:54:05 PST
Committed r164101: <http://trac.webkit.org/changeset/164101>
Note You need to log in before you can comment on or make changes to this bug.