Bug 127758

Summary: Crash in MediaPlayerPrivateAVFoundationObjC::seekToTime dereferencing RefPtr from invalid thread.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: New BugsAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jeremy Jones 2014-01-27 20:27:19 PST
Crash in MediaPlayerPrivateAVFoundationObjC::seekToTime dereferencing RefPtr from invalid thread.
Comment 1 Jeremy Jones 2014-01-27 20:30:42 PST
Created attachment 222400 [details]
Patch
Comment 2 Jer Noble 2014-01-27 20:34:34 PST
Looks like this was fixed by bug #127701. In the future, WebThreadRun() is IOS only, but callOnMainThread() will cause the passed function to be called on the web-thread (regardless of it's name).
Comment 3 Darin Adler 2014-01-28 10:05:45 PST
Comment on attachment 222400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222400&action=review

Should upload a new patch. EWS was unable to apply this one.

> Source/WebCore/ChangeLog:8
> +        A block is dispatched to the main thread; dispatch it again to the webthread.

Can’t we go straight to the web thread? Why do we need both?
Comment 4 Jer Noble 2014-01-28 10:21:30 PST
(In reply to comment #3)
> (From update of attachment 222400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222400&action=review
> 
> Should upload a new patch. EWS was unable to apply this one.
> 
> > Source/WebCore/ChangeLog:8
> > +        A block is dispatched to the main thread; dispatch it again to the webthread.
> 
> Can’t we go straight to the web thread? Why do we need both?

Indeed, and that's what we did in bug #127701.  Marking this bug as a dup of that one.

*** This bug has been marked as a duplicate of bug 127701 ***
Comment 5 Brent Fulgham 2014-02-05 16:38:33 PST
Comment on attachment 222400 [details]
Patch

Clearing patch flag since this was closed as a duplicate.