Summary: | IDB: Cursor support - Messaging, IPC, Threading plumbing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alecflett, andersca, ap, commit-queue, jsbell, sam, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 124521 | ||||||
Attachments: |
|
Description
Brady Eidson
2014-01-27 17:19:54 PST
Created attachment 222390 [details]
Patch v1
Attachment 222390 [details] did not pass style-queue:
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:87: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:563: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:584: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:605: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 4 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|