Bug 127736 - IDB: Cursor support - Messaging, IPC, Threading plumbing
Summary: IDB: Cursor support - Messaging, IPC, Threading plumbing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2014-01-27 17:19 PST by Brady Eidson
Modified: 2014-01-27 20:59 PST (History)
7 users (show)

See Also:

Attachments
Patch v1 (33.68 KB, patch)
2014-01-27 17:52 PST, Brady Eidson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-27 17:19:54 PST 
IDB: Cursor support - Messaging, IPC, Threading plumbing

In radar as <rdar://problem/15779645>
Comment 1 Brady Eidson 2014-01-27 17:52:36 PST 
Created attachment 222390 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-01-27 17:54:04 PST 
Attachment 222390 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:87:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:563:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:584:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:605:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2014-01-27 20:59:34 PST 
http://trac.webkit.org/changeset/162911