Bug 127715

Summary: [New Multicolumn] Add support for block progression axis and reverse direction
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Dave Hyatt
Reported 2014-01-27 15:22:00 PST
These are used for fancy pagination modes.
Attachments
Patch (44.35 KB, patch)
2014-01-27 15:29 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (44.32 KB, patch)
2014-01-27 15:51 PST, Dave Hyatt 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2014-01-27 15:29:50 PST
Created attachment 222368 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-27 15:31:33 PST
Attachment 222368 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:438: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:472: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:473: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:474: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:776: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2014-01-27 15:51:06 PST
Created attachment 222375 [details] Patch
Dave Hyatt
Comment 4 2014-01-27 17:22:10 PST
Fixed in r162892.
Note You need to log in before you can comment on or make changes to this bug.