Bug 127715

Summary: [New Multicolumn] Add support for block progression axis and reverse direction
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Dave Hyatt 2014-01-27 15:22:00 PST
These are used for fancy pagination modes.
Comment 1 Dave Hyatt 2014-01-27 15:29:50 PST
Created attachment 222368 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-27 15:31:33 PST
Attachment 222368 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:438:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:472:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:473:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:474:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:776:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-01-27 15:51:06 PST
Created attachment 222375 [details]
Patch
Comment 4 Dave Hyatt 2014-01-27 17:22:10 PST
Fixed in r162892.