Bug 127713

Summary:

js/dom/post-message-numeric-property.html is flaky

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2014-01-27 14:44:21 PST

js/dom/post-message-numeric-property.html has recently started to frequently fail on Mac:

----------
@@ -3,8 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS e.data[0] is 'hi'
 PASS successfullyParsed is true
 
 TEST COMPLETE
-PASS e.data[0] is 'hi'
 ----------

Comment 1 Alexey Proskuryakov 2014-01-27 14:48:01 PST

The test is inherently flaky, because it mixes up testRunner and js-test-post.js approaches to being asynchronous. That just doesn't work.

Not sure why this only started to fail recently.

Comment 2 Alexey Proskuryakov 2014-01-28 13:46:30 PST

Created attachment 222481 [details]
proposed fix

Comment 3 Geoffrey Garen 2014-01-28 13:49:32 PST

Comment on attachment 222481 [details]
proposed fix

r=me

Comment 4 WebKit Commit Bot 2014-01-28 14:21:05 PST

Comment on attachment 222481 [details]
proposed fix

Clearing flags on attachment: 222481

Committed r162961: <http://trac.webkit.org/changeset/162961>

Comment 5 WebKit Commit Bot 2014-01-28 14:21:07 PST

All reviewed patches have been landed.  Closing bug.