Bug 127702

Summary:

[iOS] preload=none prevents play()

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Eric Carlson 2014-01-27 13:24:24 PST

play() does not work when preload=none and not using the media player proxy.

Comment 1 Eric Carlson 2014-01-27 14:28:17 PST

Created attachment 222358 [details]
Proposed patch

Comment 2 Jer Noble 2014-01-27 14:33:40 PST

Comment on attachment 222358 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222358&action=review

r=me, with nit:

> Source/WebCore/html/HTMLMediaElement.cpp:4257
>  #if PLATFORM(IOS)
> -    if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback())
> -        shouldBePlaying = false;
> -    else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback())
> -        shouldBePlaying = true;
> +    if (shouldUseVideoPluginProxy()) {
> +        if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback())
> +            shouldBePlaying = false;
> +        else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback())
> +            shouldBePlaying = true;
> +    }
>  #endif

Could this #if PLATFORM(IOS) be replaced by #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)?

Comment 3 Eric Carlson 2014-01-27 14:43:32 PST

Committed r162870: https://trac.webkit.org/r162870