Bug 127701

Summary: [iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jeremyj-wk, philipj
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch none

Jer Noble
Reported 2014-01-27 13:21:22 PST
[iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
Attachments
Patch (3.79 KB, patch)
2014-01-27 13:49 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (6.06 KB, patch)
2014-01-27 13:52 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch (8.39 KB, patch)
2014-01-27 14:06 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-01-27 13:49:04 PST
Created attachment 222351 [details] Patch
Jer Noble
Comment 2 2014-01-27 13:52:11 PST
Created attachment 222352 [details] Patch
Eric Carlson
Comment 3 2014-01-27 14:01:52 PST
Comment on attachment 222352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222352&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2124 > + if (strongSelf->m_callback) > + strongSelf->m_callback->didCancelLoadingRequest(strongRequest.get()); Why do you use "strongSelf->m_callback" here, but just "m_callback" everywhere else?
Jer Noble
Comment 4 2014-01-27 14:06:32 PST
Created attachment 222355 [details] Patch Now with more weakPtr.
WebKit Commit Bot
Comment 5 2014-01-27 15:46:45 PST
Comment on attachment 222355 [details] Patch Clearing flags on attachment: 222355 Committed r162879: <http://trac.webkit.org/changeset/162879>
Jer Noble
Comment 6 2014-01-28 10:21:30 PST
*** Bug 127758 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.