Bug 127701

Summary: [iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jeremyj-wk, philipj
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch none

Description Jer Noble 2014-01-27 13:21:22 PST 
[iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
Comment 1 Jer Noble 2014-01-27 13:49:04 PST 
Created attachment 222351 [details]
Patch
Comment 2 Jer Noble 2014-01-27 13:52:11 PST 
Created attachment 222352 [details]
Patch
Comment 3 Eric Carlson 2014-01-27 14:01:52 PST 
Comment on attachment 222352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222352&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2124
> +        if (strongSelf->m_callback)
> +            strongSelf->m_callback->didCancelLoadingRequest(strongRequest.get());

Why do you use "strongSelf->m_callback" here, but just "m_callback" everywhere else?
Comment 4 Jer Noble 2014-01-27 14:06:32 PST 
Created attachment 222355 [details]
Patch

Now with more weakPtr.
Comment 5 WebKit Commit Bot 2014-01-27 15:46:45 PST 
Comment on attachment 222355 [details]
Patch

Clearing flags on attachment: 222355

Committed r162879: <http://trac.webkit.org/changeset/162879>
Comment 6 Jer Noble 2014-01-28 10:21:30 PST 
*** Bug 127758 has been marked as a duplicate of this bug. ***