Bug 127671

Summary: WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, allan.jensen, andersca, apinheiro, benjamin, cfleizach, cgarcia, cmarcelo, commit-queue, dmazzoni, d-r, eric.carlson, esprehn+autocc, fmalita, glenn, gustavo, gyuyoung.kim, japhet, jcraig, jdiggs, jer.noble, joepeck, jsbell, kangil.han, kondapallykalyan, macpherson, mario, menard, mrobinson, pdr, philipj, pnormand, samuel_white, sam, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix rniwa: review+

Joseph Pecoraro
Reported 2014-01-26 22:18:43 PST
Catches a few subtle bugs, identified some possible bugs, but overall mostly straightforward.
Attachments
[PATCH] Proposed Fix (52.48 KB, patch)
2014-01-26 22:41 PST, Joseph Pecoraro 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-01-26 22:41:36 PST
Created attachment 222303 [details] [PATCH] Proposed Fix Probably relies on the JavaScriptCore patch landing as well so I won't put cq? on it. Tested debug and release compiles.
Ryosuke Niwa
Comment 2 2014-01-27 19:09:20 PST
Comment on attachment 222303 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222303&action=review > Source/WebCore/css/SVGCSSParser.cpp:274 > + break; Nice catch! > Source/WebCore/css/StyleResolver.cpp:2230 > + return; > } > + Ditto! > Source/WebCore/rendering/AutoTableLayout.cpp:-523 > - // fall through Huh, out-dated comment. That's classic.
Joseph Pecoraro
Comment 3 2014-01-27 20:01:31 PST
Landed <http://trac.webkit.org/changeset/162907>.
Note You need to log in before you can comment on or make changes to this bug.