Bug 127668

Summary: Rename CachedImage::isImage() to isCachedImage() and add toCachedImage()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Page LoadingAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, beidson, commit-queue, japhet, kling, koivisto, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2014-01-26 19:26:01 PST
Rename CachedImage::isImage() to isCachedImage() and add toCachedImage() for type safety checking. See Bug 126761 Comment #13.
Attachments
Patch v1 (12.01 KB, patch)
2014-01-26 20:12 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-01-26 20:12:28 PST
Created attachment 222297 [details] Patch v1
Darin Adler
Comment 2 2014-01-27 10:51:38 PST
Comment on attachment 222297 [details] Patch v1 I know you got concerned about this because of RenderObject::isImage not meaning the RenderObject is a RenderImage, but I don’t see the analogy here. This new names don’t seem to be an improvement here.
David Kilzer (:ddkilzer)
Comment 3 2014-01-27 13:52:14 PST
(In reply to comment #2) > (From update of attachment 222297 [details]) > I know you got concerned about this because of RenderObject::isImage not meaning the RenderObject is a RenderImage, but I don’t see the analogy here. This new names don’t seem to be an improvement here. Okay.
Csaba Osztrogonác
Comment 4 2014-02-13 03:51:52 PST
Comment on attachment 222297 [details] Patch v1 Cleared review? from attachment 222297 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.