| Summary: | WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, joepeck, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2014-01-26 17:40:04 PST
Created attachment 222294 [details]
[PATCH] Proposed Fix
Comment on attachment 222294 [details] [PATCH] Proposed Fix Rejecting attachment 222294 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/DynamicLinkerEnvironmentExtractor.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/UniqueIDBDatabase.o DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/5370354696454144 Looks like this needs the JSC patch to land before it can land. I will land manually tomorrow. Comment on attachment 222294 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222294&action=review > Source/WebKit2/Shared/UserData.cpp:157 > case API::Object::Type::Point: > static_cast<const API::Point&>(object).encode(encoder); > + break; > > case API::Object::Type::Rect: > static_cast<const API::Rect&>(object).encode(encoder); > + break; Wow, it caught a real bug! |