Bug 127664

Summary:

WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, joepeck, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	darin: review+

Joseph Pecoraro

Reported 2014-01-26 17:31:06 PST

Easy! Only a few instances.

Attachments
[PATCH] Proposed Fix (4.97 KB, patch) 2014-01-26 17:32 PST, Joseph Pecoraro	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-01-26 17:32:23 PST

Created attachment 222293 [details] [PATCH] Proposed Fix

Darin Adler

Comment 2 2014-01-27 10:49:43 PST

Comment on attachment 222293 [details] [PATCH] Proposed Fix r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about

Joseph Pecoraro

Comment 3 2014-01-27 10:58:05 PST

(In reply to comment #2) > (From update of attachment 222293 [details]) > r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about That was a addressed in the JSC patch that hasn't landed yet.

Joseph Pecoraro

Comment 4 2014-01-27 20:11:53 PST

Landed <http://trac.webkit.org/changeset/162908>

Note You need to log in before you can comment on or make changes to this bug.