Bug 127664

Summary: WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, joepeck, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix darin: review+

Description Joseph Pecoraro 2014-01-26 17:31:06 PST 
Easy! Only a few instances.
Comment 1 Joseph Pecoraro 2014-01-26 17:32:23 PST 
Created attachment 222293 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2014-01-27 10:49:43 PST 
Comment on attachment 222293 [details]
[PATCH] Proposed Fix

r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about
Comment 3 Joseph Pecoraro 2014-01-27 10:58:05 PST 
(In reply to comment #2)
> (From update of attachment 222293 [details])
> r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about

That was a addressed in the JSC patch that hasn't landed yet.
Comment 4 Joseph Pecoraro 2014-01-27 20:11:53 PST 
Landed <http://trac.webkit.org/changeset/162908>