Bug 127661

Summary: [New Multicolumn] Change the axis property to be a boolean like other isInline checks
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dave Hyatt
Reported 2014-01-26 15:44:24 PST
Change the axis property to be a boolean like other isInline checks. This makes it easier to share between the old/new multi-column and matches other uses of isInline/childrenInline() etc. in the engine.
Attachments
Patch (12.41 KB, patch)
2014-01-26 15:45 PST, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2014-01-26 15:45:09 PST
Created attachment 222290 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-01-26 15:46:39 PST
Comment on attachment 222290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222290&action=review > Source/WebCore/rendering/RenderMultiColumnFlowThread.h:38 > - > + Added whitespace.
Dave Hyatt
Comment 3 2014-01-26 19:52:58 PST
Landed in r162822.
Note You need to log in before you can comment on or make changes to this bug.