Bug 127643

Summary: Remove dead code from the JSC profiler
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: JavaScriptCoreAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, graouts, joepeck, mark.lam, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2014-01-25 21:40:20 PST
There is dead code in LegacyProfiler and ProfileNode that can be removed. It is there from when UI features like exclude and focus were implemented on the backend.
Attachments
Patch (23.37 KB, patch)
2014-01-25 21:44 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2014-01-25 21:44:46 PST
Created attachment 222252 [details] Patch
Mark Lam
Comment 2 2014-01-25 21:51:39 PST
Comment on attachment 222252 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-01-25 22:26:07 PST
Comment on attachment 222252 [details] Patch Clearing flags on attachment: 222252 Committed r162796: <http://trac.webkit.org/changeset/162796>
WebKit Commit Bot
Comment 4 2014-01-25 22:26:09 PST
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 5 2014-01-25 22:51:08 PST
There was a dataLog reference to the obsolete “visible” timers that was breaking the debug build. This has been fixed in r162797: <http://trac.webkit.org/r162797>.
Note You need to log in before you can comment on or make changes to this bug.