| Summary: | Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2014-01-25 14:43:18 PST
Created attachment 222236 [details]
Patch
Comment on attachment 222236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222236&action=review > Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:37 > +static SQLiteDatabaseTrackerClient* s_staticSQLiteDatabaseTrackerClient = 0; nullptr (or omit) > Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:40 > +static Mutex& transactionInProgressMutex() Can we use C++ standard library locking instead of WTF locking? > Source/WebCore/platform/sql/SQLiteDatabaseTracker.h:43 > +#if !ASSERT_DISABLED > +bool hasTransactionInProgress(); > +#endif // !ASSERT_DISABLED That endif comment. Really? (In reply to comment #2) > (From update of attachment 222236 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222236&action=review > > > Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:37 > > +static SQLiteDatabaseTrackerClient* s_staticSQLiteDatabaseTrackerClient = 0; > > nullptr (or omit) > > > Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:40 > > +static Mutex& transactionInProgressMutex() > > Can we use C++ standard library locking instead of WTF locking? > > > Source/WebCore/platform/sql/SQLiteDatabaseTracker.h:43 > > +#if !ASSERT_DISABLED > > +bool hasTransactionInProgress(); > > +#endif // !ASSERT_DISABLED > > That endif comment. Really? Heh, I just moved the file, but I will clean it up before landing. Committed r162787: <http://trac.webkit.org/changeset/162787> |