Bug 127625

Summary: Remove atomicIncrement/atomicDecrement
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eric.carlson, glenn, jer.noble, philipj
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2014-01-25 11:54:02 PST
Remove atomicIncrement/atomicDecrement
Attachments
Patch (19.42 KB, patch)
2014-01-25 11:56 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (19.42 KB, patch)
2014-01-25 12:32 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-25 11:56:51 PST
Created attachment 222224 [details] Patch
Andreas Kling
Comment 2 2014-01-25 12:27:32 PST
Comment on attachment 222224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222224&action=review > Source/WTF/wtf/ThreadSafeRefCounted.h:97 > - if (atomicDecrement(&m_refCount) <= 0) { > + if (++m_refCount <= 0) { Bug!
Anders Carlsson
Comment 3 2014-01-25 12:32:58 PST
Created attachment 222226 [details] Patch
Andreas Kling
Comment 4 2014-01-25 12:39:25 PST
Comment on attachment 222226 [details] Patch r=me
Anders Carlsson
Comment 5 2014-01-25 13:12:13 PST
Committed r162777: <http://trac.webkit.org/changeset/162777>
Note You need to log in before you can comment on or make changes to this bug.