Bug 127625

Summary: Remove atomicIncrement/atomicDecrement
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eric.carlson, glenn, jer.noble, philipj
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Anders Carlsson 2014-01-25 11:54:02 PST
Remove atomicIncrement/atomicDecrement
Comment 1 Anders Carlsson 2014-01-25 11:56:51 PST
Created attachment 222224 [details]
Patch
Comment 2 Andreas Kling 2014-01-25 12:27:32 PST
Comment on attachment 222224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222224&action=review

> Source/WTF/wtf/ThreadSafeRefCounted.h:97
> -        if (atomicDecrement(&m_refCount) <= 0) {
> +        if (++m_refCount <= 0) {

Bug!
Comment 3 Anders Carlsson 2014-01-25 12:32:58 PST
Created attachment 222226 [details]
Patch
Comment 4 Andreas Kling 2014-01-25 12:39:25 PST
Comment on attachment 222226 [details]
Patch

r=me
Comment 5 Anders Carlsson 2014-01-25 13:12:13 PST
Committed r162777: <http://trac.webkit.org/changeset/162777>