Bug 127623

Summary: Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 164473    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Darin Adler
Reported 2014-01-25 10:53:47 PST
Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
Attachments
Patch (34.18 KB, patch)
2014-01-25 10:58 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (34.16 KB, patch)
2014-01-25 11:42 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (34.17 KB, patch)
2014-01-25 11:43 PST, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-01-25 10:58:29 PST
Created attachment 222219 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-25 10:59:54 PST
Attachment 222219 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:28: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2014-01-25 11:42:09 PST
Created attachment 222221 [details] Patch
Darin Adler
Comment 4 2014-01-25 11:43:09 PST
Created attachment 222222 [details] Patch
Darin Adler
Comment 5 2014-01-25 13:32:05 PST
Committed r162782: <http://trac.webkit.org/changeset/162782>
Daniel Bates
Comment 6 2014-07-06 14:14:58 PDT
*** Bug 126857 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.