Bug 127615

Summary: Web Inspector: Position the completion suggestions popup below if there is room
Product: WebKit Reporter: Diego Pino <dpino>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Diego Pino
Reported 2014-01-25 01:26:08 PST
When filling the value of a CSS property, a completion list with suggestions pops up. Currently the popup is positioned above the edited CSS property is there is more room than below. A FIXME recommends to always position the popup below if there is room enough.
Attachments
Patch (1.93 KB, patch)
2014-01-25 01:30 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (1.91 KB, patch)
2014-01-25 14:49 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-25 01:26:18 PST
<rdar://problem/15908842>
Diego Pino
Comment 2 2014-01-25 01:30:43 PST
Created attachment 222199 [details] Patch
Joseph Pecoraro
Comment 3 2014-01-25 09:35:06 PST
Comment on attachment 222199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222199&action=review Nice! r=me with some style nits. > Source/WebInspectorUI/ChangeLog:6 > + Web Inspector: Position the completion suggestions popup below if > + there is room enough. > + > + https://bugs.webkit.org/show_bug.cgi?id=127615 Style: `./Tools/Scripts/prepare-ChangeLog -b 127615` would not wrap the title line and would put the bugzilla bug on the next line without an empty line between. > Source/WebInspectorUI/UserInterface/CompletionSuggestionsView.js:153 > + // Position the suggestions below the anchor. If there is no room, position the suggestions above Style: Comments in WebKit are full sentences. This second sentence should end in a period.
Diego Pino
Comment 4 2014-01-25 14:49:08 PST
Created attachment 222237 [details] Patch
Joseph Pecoraro
Comment 5 2014-01-25 16:35:23 PST
Comment on attachment 222237 [details] Patch r=me
WebKit Commit Bot
Comment 6 2014-01-25 17:03:51 PST
Comment on attachment 222237 [details] Patch Clearing flags on attachment: 222237 Committed r162790: <http://trac.webkit.org/changeset/162790>
WebKit Commit Bot
Comment 7 2014-01-25 17:03:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.