Bug 127584

Summary:

[New Multicolumn] Don't destroy all the renderers when a multi-column block stops being multi-column (and vice versa)

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bdakin: review+

Description Dave Hyatt 2014-01-24 13:56:28 PST

Don't destroy all the renderers when a multi-column block stops being multi-column (and vice versa). We make the logic for this share with the old multi-column code so that the two are closer in line.

Comment 1 Dave Hyatt 2014-01-24 14:02:37 PST

Created attachment 222153 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-24 14:03:42 PST

Attachment 222153 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.h:435:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Dave Hyatt 2014-01-24 14:48:21 PST

Landed in r162726.