Bug 127580

Summary:

Replace LayoutUnit() calls to a more descriptive LayoutUnit::fromPixel(int).

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description zalan 2014-01-24 13:30:45 PST

LayoutUnit(1) is highly ambiguous. It is intended to set one (CSS) pixel, but it could read as 1 layout unit (1/64th of pixel atm)

Comment 1 zalan 2014-01-24 14:23:40 PST

Created attachment 222155 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-24 16:17:31 PST

Comment on attachment 222155 [details]
Patch

Clearing flags on attachment: 222155

Committed r162737: <http://trac.webkit.org/changeset/162737>

Comment 3 WebKit Commit Bot 2014-01-24 16:17:33 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2014-01-28 00:43:08 PST

<rdar://problem/15923398>