Bug 127556

Summary:

Rename various RenderFlexibleBox variables and arguments to match the naming from the spec

Product:

WebKit

Reporter:

Peter Molnar <pmolnar.u-szeged>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser, svillar, syoichi

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Peter Molnar 2014-01-24 07:24:29 PST

This should make it easier to understand the code. I have also simplified some calculations
and gave some expressions their own variables.

Merged from Blink: https://src.chromium.org/viewvc/blink?revision=153288&view=revision

Comment 1 Peter Molnar 2014-01-24 07:25:28 PST

Created attachment 222107 [details]
patch

Comment 2 Michael Catanzaro 2016-09-17 07:19:03 PDT

Comment on attachment 222107 [details]
patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

Comment 3 Sergio Villar Senin 2021-09-13 01:14:44 PDT

Right, this was already fixed in r213149 BTW.