Bug 127552

Summary:

Fix build warnings by unused parameter

Product:

WebKit

Reporter:

Jinwoo Song <jinwoo7.song>

Component:

WebKit Misc.

Assignee:

Jinwoo Song <jinwoo7.song>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

benjamin, gyuyoung.kim, kling, ossy, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Jinwoo Song

Reported 2014-01-24 02:44:58 PST

In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebLoaderClient.h:30:0, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.h:55, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:28: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:90:18: warning: unused parameter ‘addedItem’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:90:18: warning: unused parameter ‘removedItems’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:94:44: warning: unused parameter ‘unavailabilityDescription’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:94:44: warning: unused parameter ‘useBlockedPluginTitle’ [-Wunused-parameter] In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:32:0: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:53:18: warning: unused parameter ‘originatingFrame’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:53:18: warning: unused parameter ‘originalRequest’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:53:18: warning: unused parameter ‘userData’ [-Wunused-parameter] In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:32:0: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:54:18: warning: unused parameter ‘frameName’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:54:18: warning: unused parameter ‘userData’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:55:18: warning: unused parameter ‘canShowMIMEType’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:55:18: warning: unused parameter ‘userData’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:56:18: warning: unused parameter ‘userData’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:499:6: warning: unused parameter ‘changed’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:617:26: warning: unused parameter ‘frame’ [-Wunused-parameter] /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2090:6: warning: unused parameter ‘isInitialState’ [-Wunused-parameter]

Attachments
Patch (7.10 KB, patch) 2014-01-24 02:46 PST, Jinwoo Song	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jinwoo Song

Comment 1 2014-01-24 02:46:46 PST

Created attachment 222090 [details] Patch

Gyuyoung Kim

Comment 2 2014-01-24 04:03:41 PST

Comment on attachment 222090 [details] Patch LGTM

Anders Carlsson

Comment 3 2014-01-24 18:24:44 PST

Comment on attachment 222090 [details] Patch I think you can just remove the parameters instead of commenting them out.

Jinwoo Song

Comment 4 2014-01-24 18:35:11 PST

(In reply to comment #3) > (From update of attachment 222090 [details]) > I think you can just remove the parameters instead of commenting them out. I commented out the parameters which can not infer the meanings from the parameter types because that was a consensus discussed before as I know.

Gyuyoung Kim

Comment 5 2014-01-24 22:39:00 PST

(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 222090 [details] [details]) > > I think you can just remove the parameters instead of commenting them out. > > I commented out the parameters which can not infer the meanings from the parameter types because that was a consensus discussed before as I know. There is a rule by Darin, https://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html Personally, I also prefer to remove parameter name in this case :)

Csaba Osztrogonác

Comment 6 2015-02-26 06:31:17 PST

There is no warning now.

Note You need to log in before you can comment on or make changes to this bug.