Bug 127549

Summary: [WK2][EFL] Fix a build break on debug mode
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit2Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Gyuyoung Kim 2014-01-24 01:36:44 PST
There are below build error when building WK2 EFL on debug mode. It looks we need to use static_cast<uint64_t> for the SessionTracker's const variables.


[ 86%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o
/home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:617:26: warning: unused parameter ‘frame’ [-Wunused-parameter]
/home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2090:6: warning: unused parameter ‘isInitialState’ [-Wunused-parameter]
Linking CXX shared library ../../lib/libewebkit2.so
CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o: In function `WebKit::WebPage::sessionID() const':
/home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2132: undefined reference to `WebKit::SessionTracker::legacyPrivateSessionID'
/home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2132: undefined reference to `WebKit::SessionTracker::defaultSessionID'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/libewebkit2.so.0.1.0] Error 1
Comment 1 Gyuyoung Kim 2014-01-24 01:39:04 PST
Created attachment 222088 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-01-24 03:50:01 PST
I already have a fix for it: https://bugs.webkit.org/show_bug.cgi?id=127496
A little bit different solution, but both of them work.
Comment 3 Gyuyoung Kim 2014-01-24 03:51:59 PST
(In reply to comment #2)
> I already have a fix for it: https://bugs.webkit.org/show_bug.cgi?id=127496
> A little bit different solution, but both of them work.

Looks better solution than me !
Comment 4 Gyuyoung Kim 2014-01-24 03:55:04 PST

*** This bug has been marked as a duplicate of bug 127496 ***