| Summary: | Web Inspector: Refactor bar combining logic into a TimelineRecordBar helper | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Timothy Hatcher
2014-01-23 18:10:19 PST
Created attachment 222063 [details]
Patch
Created attachment 222065 [details]
Screenshot
Comment on attachment 222063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222063&action=review Clean! r=me > Source/WebInspectorUI/ChangeLog:49 > + Lazy create DOM elements. Support rendering one or both segments. Doing this lets Typo: Lazy => Lazily > Source/WebInspectorUI/ChangeLog:50 > + combined inactive segments to sit behind multiple active segments. Typo: "combined inactive segments to sit" => "combined inactive segments sit" > Source/WebInspectorUI/UserInterface/NetworkTimelineOverviewGraph.css:27 > + padding-top: 3px Nit: Missing semicolon. > Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:238 > + var barEndTime = this._records.reduce(function(previousValue, currentValue) { return Math.max(previousValue, currentValue.endTime); }, 0); The list is no longer sorted? Nit: Up above, out of context, there is a "return;" that should be "return false;" |