Bug 127527

Summary: Add an APILoaderClient base class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Anders Carlsson 2014-01-23 17:42:54 PST
Add an APILoaderClient base class
Comment 1 Anders Carlsson 2014-01-23 17:48:27 PST
Created attachment 222051 [details]
Patch
Comment 2 Tim Horton 2014-01-23 17:51:22 PST
Comment on attachment 222051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222051&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:811
> -    return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient().client().base.clientInfo;
> +//    return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient()->client().base.clientInfo;
> +    return 0;

wut
Comment 3 Tim Horton 2014-01-23 17:52:07 PST
Comment on attachment 222051 [details]
Patch

other than that, seems fine
Comment 4 Anders Carlsson 2014-01-23 17:55:42 PST
Committed r162670: <http://trac.webkit.org/changeset/162670>